uschindler commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-748519083
I will rewrite that stuff a bit, so you can pass a mergeBufferSize when creating the directory, but the value is adjusted according to the file system. I don't want hardcoded 512 bytes, it should use real. Like with MMAPDirectory, the buffer size can be passed in as a hint, but internally the directory uses whatever is a good choice aligned to the real block size. If you want to get the exact size, I will add a getter to retrieve it. Give me some time to understand the code and adjust. The hardcoded constants are not valid for all platforms and were choosen by @mikemccand as he had no way to figure them out with his native C code. The JDK gives everything, so we don't need to hardcode 512 bytes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
