uschindler edited a comment on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-748195186
Hi, with the warning I can't really help much, I can only recommend to call out to OpenJDK mailing list, how to disable the warning. Of course we should always use `-release` flag. IMHO, instead of adding `@SuppressWarnings`, you should also review the Gradle config, if there are some `-Xlint`options enabled that cause this. I was warning the people who added "fail on err / Werror" already that this should only ever be done if you explicitely use a positive list of warnings you want to suppress. We may also disable Werror for this module. If nothing helps, I'd use the following workaround - it's a simple enum: - lookup the class with `Class#forName()` - lookup the enum constant using the class API, cast to interface OpenOption, and assign it to a final static constant in the DirectIODirectory class This would also allow us to bail out with an IOException when the user try to isntantiate the directory, when the open option is not available (e.g., foreign JDK version not based on OpenJDK) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
