[GitHub] [lucene-solr] jbampton commented on a change in pull request #2137: SOLR-14251 Add option skipFreeSpaceCheck to skip checking for availble disk space before splitting shards. Useful with shared file systems like HDFS

[GitBox]

jbampton commented on a change in pull request #2137:
URL: https://github.com/apache/lucene-solr/pull/2137#discussion_r543419505



##########
File path: 
solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java
##########
@@ -129,10 +130,16 @@ public boolean split(ClusterState clusterState, 
ZkNodeProps message, NamedList<O
       throw new SolrException(SolrException.ErrorCode.SERVER_ERROR, 
"Interrupted.");
     }
 
+

Review comment:
       ```suggestion
   ```

##########
File path: 
solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java
##########
@@ -129,10 +130,16 @@ public boolean split(ClusterState clusterState, 
ZkNodeProps message, NamedList<O
       throw new SolrException(SolrException.ErrorCode.SERVER_ERROR, 
"Interrupted.");
     }
 
+
     RTimerTree t;
     if 
(ocmh.overseer.getCoreContainer().getNodeConfig().getMetricsConfig().isEnabled())
 {
       t = timings.sub("checkDiskSpace");
-      checkDiskSpace(collectionName, slice.get(), parentShardLeader, 
splitMethod, ocmh.cloudManager);
+      boolean skipFreeSpaceCheck = message.getBool(SKIP_FREE_SPACE_CHECK, 
false);
+      if(skipFreeSpaceCheck) {

Review comment:
       ```suggestion
         if (skipFreeSpaceCheck) {
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org