ErickErickson commented on pull request #2129: URL: https://github.com/apache/lucene-solr/pull/2129#issuecomment-742891680
It already fails on _tabs_ rather than spaces, but failing on too many spaces isn’t checked. That said, rather than a one-off for indentation, I’d rather see the effort go here rather than a separate precommit check….: https://issues.apache.org/jira/browse/LUCENE-9564 and SOLR-14920… BTW, 'gradlew check’ does all the precommit tasks as well as run tests... > On Dec 10, 2020, at 2:55 PM, Mayya Sharipova <notificati...@github.com> wrote: > > > Merged #2129 into master. > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub, or unsubscribe. > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
