[
https://issues.apache.org/jira/browse/LUCENE-9629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Feng Guo updated LUCENE-9629:
-----------------------------
Description:
In the class ForkUtil, mask values have been computed and stored in static
final vailables, but they are recomputed for every encoding, which may be
unnecessary.
anther small fix is that change
{code:java}
remainingBitsPerValue > remainingBitsPerLong{code}
to
{code:java}
remainingBitsPerValue >= remainingBitsPerLong{code}
otherwise
{code:java}
if (remainingBitsPerValue == 0) {
idx++;
remainingBitsPerValue = bitsPerValue;
}
{code}
these code will never be used.
was:
In the class ForkUtil, mask values have been computed and stored in static
final vailables, but they are recomputed for every encoding, which may be
unnecessary.
anther small fix is that `remainingBitsPerValue > remainingBitsPerLong` to
'remainingBitsPerValue >= remainingBitsPerLong', otherwise
```
if (remainingBitsPerValue == 0) {
idx++;
remainingBitsPerValue = bitsPerValue;
}
```
these code will never be used.
> Use computed mask values in ForUtil
> -----------------------------------
>
> Key: LUCENE-9629
> URL: https://issues.apache.org/jira/browse/LUCENE-9629
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/codecs
> Reporter: Feng Guo
> Priority: Major
>
> In the class ForkUtil, mask values have been computed and stored in static
> final vailables, but they are recomputed for every encoding, which may be
> unnecessary.
> anther small fix is that change
> {code:java}
> remainingBitsPerValue > remainingBitsPerLong{code}
> to
> {code:java}
> remainingBitsPerValue >= remainingBitsPerLong{code}
> otherwise
>
> {code:java}
> if (remainingBitsPerValue == 0) {
> idx++;
> remainingBitsPerValue = bitsPerValue;
> }
> {code}
>
> these code will never be used.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
