[
https://issues.apache.org/jira/browse/LUCENE-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17240633#comment-17240633
]
Tomoko Uchida commented on LUCENE-9623:
---------------------------------------
bq. We also need some testing of the artifacts! Our standard test environment
can't do testing of module system. This needs some "integration" tests: A
project using the JAR files on module path - no classpath.
I was also wondering how we should test if the modules are correctly
generated... do we need a test fixture or framework for it ??
bq. Ah I have seen in the examples above that it looks like JDEPS creates the
services correctly.
Yes, I think so. I copy-pasted the auto generated module-info for only one
analysis module to show the "provides" descriptor, but codecs look also just
fine to me (though I have not yet closely looked at all modules).
> Add module descriptor (module-info.java) to lucene jars
> -------------------------------------------------------
>
> Key: LUCENE-9623
> URL: https://issues.apache.org/jira/browse/LUCENE-9623
> Project: Lucene - Core
> Issue Type: Improvement
> Components: general/build
> Affects Versions: master (9.0)
> Reporter: Tomoko Uchida
> Priority: Major
> Attachments: generate-all-module-info.sh
>
>
> For a starter, module descriptors can be automatically generated by jdeps
> utility.
> There are two choices.
> 1. generate "open" modules which allows reflective accesses with
> --generate-open-module option
> 2. generate non-open modules with --generate-module-info option
> Which is the better - not fully sure, but maybe 2 (non-open modules)?
> Also, we need to choose proper module names - just using gradle project path
> for it is OK?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
