[
https://issues.apache.org/jira/browse/SOLR-15005?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-15005.
---------------------------------
Resolution: Won't Fix
Fair enough Hoss... I enjoy reading your wisdom.
Indeed you make a good point about MDC; that should ameliorate wanting to know
which handler is logging.
> RequestHandlerBase's logger name should point to the implementation class
> -------------------------------------------------------------------------
>
> Key: SOLR-15005
> URL: https://issues.apache.org/jira/browse/SOLR-15005
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: logging
> Reporter: David Smiley
> Priority: Minor
>
> RequestHandlerBase is an abstract class that defines a private static Logger
> with a logger name of this very class. I think it should point to the
> implementing class (getClass()). This would require it be non-static. It's
> used in just one spot, from a method that isn't static, so this will work.
> Do we go farther and declare as protected and remove static loggers in all
> subclasses, so long as they aren't being referenced from static methods there?
> See recent comments at the end of SOLR-8330
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]