David Smiley created SOLR-15001:
-----------------------------------
Summary: Docker: require init_var_solr.sh; don't init in Dockerfile
Key: SOLR-15001
URL: https://issues.apache.org/jira/browse/SOLR-15001
Project: Solr
Issue Type: Improvement
Security Level: Public (Default Security Level. Issues are Public)
Components: Docker
Reporter: David Smiley
Assignee: David Smiley
I propose removing initialization of /var/solr from the Dockerfile, thus
leaving only init_var_solr to do this. The fact that it's in two places means
that the image has two solr.xml, two zoo.cfg, two log4j2.xml. This
initialization itself must be maintained twice. That leads to confusion (it did
with my colleagues and I) about which copy is going to be used. Imagine you are
basing your company Solr Dockerfile on top of this one (i.e. official is the
FROM) and need to do modifications. Do you modify
/opt/solr/server/solr/solr.xml? Surprise surprise, sometimes it is copied to
/var/solr/data/ by the init_var_solr script but _sometimes_ it isn't because
the Dockerfile here will do it, thus ignoring the customizations made to
solr.xml in the next image layer.
After making this change, our wonderful tests exposed that solr-demo wasn't
invoking init_var_solr.
THIS ISSUE IS COPIED FROM https://github.com/docker-solr/docker-solr/pull/354
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
