gerlowskija commented on pull request #2056: URL: https://github.com/apache/lucene-solr/pull/2056#issuecomment-724828898
Hey @munendrasn new code should address your concerns: - handling for the string values that come through when requests are made using XML. - handling for the "add-distinct" class of operations. - additional tests to cover the two cases above. I ended up _not_ going with the approach you suggested above of using `toNativeType()` to convert the whole list of "original" values, primarily for the performance concern I mentioned above. I'm not in love with the code I've got now though - the type checks are pretty ugly. So maybe I'll flip on this after a bit more consideration. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
