msokolov commented on a change in pull request #2022:
URL: https://github.com/apache/lucene-solr/pull/2022#discussion_r518902276
##########
File path: lucene/core/src/java/org/apache/lucene/index/VectorValues.java
##########
@@ -74,6 +74,18 @@ public BytesRef binaryValue() throws IOException {
throw new UnsupportedOperationException();
}
+ /**
+ * Return the k nearest neighbor documents as determined by comparison of
their vector values
+ * for this field, to the given vector, by the field's search strategy. If
the search strategy is
+ * reversed, lower values indicate nearer vectors, otherwise higher scores
indicate nearer
+ * vectors. Unlike relevance scores, vector scores may be negative.
+ * @param target the vector-valued query
+ * @param k the number of docs to return
+ * @param fanout control the accuracy/speed tradeoff - larger values give
better recall at higher cost
Review comment:
Yeah that's a good point. While experimenting with GloVe I'm learning
that different settings are appropriate for different vectors, so field-level
control might be needed. I'm not sure how codec-level controls are exposed.
Don't Codecs get created automatically using no-args constructors and service
autodiscovery? Did you mean something like perFieldVectorFormat? Except I doubt
we need a new format; it's more about some metadata values that we would store
in the field, so I think yeah it would go in FieldInfo. But I'm reluctant to
expose hnsw-specific hyperparameters in `VectorField`, which we want to support
other algorithms as well. Maybe this is a good use case for
`IndexableField.getAttributes()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
