mayya-sharipova opened a new pull request #2063:
URL: https://github.com/apache/lucene-solr/pull/2063
Currently, if search sort is equal to index sort, we have an early
termination in TopFieldCollector. As we work to enhance comparators
to provide skipping functionality (PR #1351), we would like to
move this termination functionality on index sort from
TopFieldCollector to comparators.
This patch does the following:
- Add method usesIndexSort to LeafFieldComparator
- Make numeric comparators aware of index sort and early terminate on
collecting all competitive hits
- Move TermValComparator and TermOrdValComparator from FieldComparator
to comparator package, for all comparators to be in the same package
- Enhance TermValComparator to provide skipping functionality when
index is sorted
One item left for TODO for a following PR is to remove the logic of
early termniation from TopFieldCollector. We can do that once
we ensure that all BulkScorers are using iterators from collectors
than can skip non-competitive docs.
Relates to #1351
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
