sigram commented on a change in pull request #2040:
URL: https://github.com/apache/lucene-solr/pull/2040#discussion_r513485514
##########
File path: solr/core/src/java/org/apache/solr/metrics/SolrMetricManager.java
##########
@@ -423,13 +429,13 @@ public boolean hasRegistry(String name) {
/**
* Check for predefined shared registry names. This compares the input name
* with normalized names of predefined shared registries -
- * {@link #JVM_REGISTRY} and {@link #JETTY_REGISTRY}.
+ * {@link #JVM_REGISTRY}, {@link #JETTY_REGISTRY}, and {@link
#OVERSEER_REGISTRY}
Review comment:
Overseer registry CANNOT be a shared registry because it's possible to
have multiple Overseers in a single JVM, especially in unit tests. This should
be a regular per-CoreContainer registry, which is created within the scope of
the instance available from CC.getMetricManager().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
