dsmiley commented on a change in pull request #1993:
URL: https://github.com/apache/lucene-solr/pull/1993#discussion_r508972018
##########
File path: .gitignore
##########
@@ -1,42 +1,33 @@
-# .
-/eclipse-build
-/maven-build
-/classes
-build
-/idea-build
-dist
-lib
-test-lib
-/*~
-/build.properties
-/.idea
-lucene/**/*.iml
-parent.iml
-*.ipr
-*.iws
-/*.iml
-.project
-.classpath
-.settings
-/.caches
-/prj.el
-bin
-/bin
-/bin.*
-pom.xml
-/nbproject
-/nb-build
-.pydevproject
-__pycache__
-/dev-tools/scripts/scripts.iml
-.DS_Store
+### At the root
+
+/.idea/
+# Ignore the generated local settings file.
+/gradle.properties
+
+/prj.el # TODO?
+
+# Eclipse
+/.project
+/.classpath
+/.settings/
+
+### Any dir
-build/
.gradle/
-.idea/
+build/
-# Ignore the generated local settings file.
-gradle.properties
+# macOS
+.DS_Store
+
+# Eclipse Gradle oddity
+**/bin/default/
Review comment:
What you refer to as "the other Eclipse section" is in a higher level
"at the root", and this rule here is not at the root, it's at any directory.
That said, I suppose I should toss out that "at the root" label as it's better
to put all these eclipse rules together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
