HoustonPutman commented on a change in pull request #1996:
URL: https://github.com/apache/lucene-solr/pull/1996#discussion_r508203430
##########
File path: solr/core/src/java/org/apache/solr/handler/ClusterAPI.java
##########
@@ -133,6 +134,62 @@ public void create(PayloadObj<CreateConfigInfo> obj)
throws Exception {
}
+ @EndPoint(method = POST,
+ path = "/cluster/configs/{name}",
+ permission = CONFIG_EDIT_PERM
+ )
+ public void uploadConfigSet(SolrQueryRequest req, SolrQueryResponse rsp)
throws Exception {
+ req = wrapParams(req,
+ "action", ConfigSetParams.ConfigSetAction.UPLOAD.toString(),
+ CommonParams.NAME, req.getPathTemplateValues().get("name"));
+ configSetsHandler.handleRequestBody(req, rsp);
+ }
+
+ @EndPoint(method = PUT,
+ path = "/cluster/configs/{name}",
+ permission = CONFIG_EDIT_PERM
+ )
+ public void uploadConfigSetWithOverwrite(SolrQueryRequest req,
SolrQueryResponse rsp) throws Exception {
+ req = wrapParams(req,
+ "action", ConfigSetParams.ConfigSetAction.UPLOAD.toString(),
+ CommonParams.NAME, req.getPathTemplateValues().get("name"),
+ ConfigSetParams.OVERWRITE, true,
+ ConfigSetParams.CLEANUP,
req.getParams().getBool(ConfigSetParams.CLEANUP, false));
+ configSetsHandler.handleRequestBody(req, rsp);
+ }
+
+ @EndPoint(method = POST,
Review comment:
We do support the nested structure.
The `/files/` part defines what the * after it is, and allows us to extend
in the future. For example possible adding a
`/cluster/configs/{configname}/properties` PUT action to update the properties
for that config. It fits pretty well in the
[guidelines](https://restfulapi.net/resource-naming/).
It's not that important to me though if y'all agree with taking it out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
