sarowe commented on pull request #1965: URL: https://github.com/apache/lucene-solr/pull/1965#issuecomment-709598453
> Oh I added it to the Factory class which already has a solr xml example (https://github.com/apache/lucene-solr/pull/1965/files#diff-6efa63ada0f2520335d809359639f4c280a4ffbed3cac47927f2e47009f5f7f7R41) Yeah I saw that, but the Filter is an entry point independent of the Factory, and its class comment contains a brief description of the filter: https://github.com/apache/lucene-solr/blob/master/lucene/analysis/common/src/java/org/apache/lucene/analysis/miscellaneous/TypeAsSynonymFilter.java#L29-L32 . I was thinking another phrase or two could be added mentioning the ignore list and the flag masking capabilities, but if you disagree, that's fine. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
