[
https://issues.apache.org/jira/browse/SOLR-14654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213911#comment-17213911
]
Cassandra Targett commented on SOLR-14654:
------------------------------------------
[~noble.paul], This commit broke the Ref Guide build on master:
https://github.com/apache/lucene-solr/commit/03fe8e52609a76572a1e39084a2f75471c65614e
The page {{blob-store-api.adoc}} was removed, and while the link to the page
was removed from its parent {{configuration-apis.adoc}}, the definition of the
blob-store-api.adoc page as its child was not. At the top of the page there is
a section that defines all of the pages that are considered it's children:
{code}
= Configuration APIs
:page-children: blob-store-api, config-api, request-parameters-api,
managed-resources
{code}
When a page is removed, it must also be removed from the page-children list or
the build will fail.
Since this change was on master only, it's very confusing how this sort of
thing can happen again with this issue. Gradle has a task to build the Ref
Guide that requires *no* local dependencies - {{gradlew buildSite}}. It takes
only 2-3 minutes. It would have failed and shown you that this parent page
still contained a reference to a child that no longer exists. Since you were
doing a commit only for Ref Guide changes, it becomes even stranger that you
wouldn't check that you'd made all the required changes successfully.
> Remove plugin loading from .system collection (for 9.0)
> -------------------------------------------------------
>
> Key: SOLR-14654
> URL: https://issues.apache.org/jira/browse/SOLR-14654
> Project: Solr
> Issue Type: Task
> Reporter: Noble Paul
> Priority: Major
> Fix For: master (9.0)
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> This code must go from master
> all places where "runtimeLib" can be used will be removed from 9.0 . With
> the new package system in place we don;t need this anymore
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
