HoustonPutman commented on a change in pull request #1977:
URL: https://github.com/apache/lucene-solr/pull/1977#discussion_r503580189
##########
File path:
solr/core/src/java/org/apache/solr/handler/admin/ConfigSetsHandler.java
##########
@@ -170,10 +170,14 @@ private void handleConfigUploadRequest(SolrQueryRequest
req, SolrQueryResponse r
boolean overwritesExisting = zkClient.exists(configPathInZk, true);
- if (overwritesExisting &&
!req.getParams().getBool(ConfigSetParams.OVERWRITE, false)) {
- throw new SolrException(ErrorCode.BAD_REQUEST,
- "The configuration " + configSetName + " already exists in
zookeeper");
- }
+ // Get upload parameters
+ String singleFilePath = req.getParams().get(ConfigSetParams.FILE_PATH, "");
+ boolean allowOverwrite =
req.getParams().getBool(ConfigSetParams.OVERWRITE, false);
+ // Cleanup is not allowed while using singleFilePath upload
+ boolean cleanup = singleFilePath.isEmpty() &&
req.getParams().getBool(ConfigSetParams.CLEANUP, false);
Review comment:
Added error handling for that and cases where a bad filePath is given.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
