[GitHub] [lucene-solr] iverase commented on pull request #1907: LUCENE-9538: Detect polygon self-intersections in the Tessellator

[GitBox]

iverase commented on pull request #1907:
URL: https://github.com/apache/lucene-solr/pull/1907#issuecomment-707042029


   Thinking more about this, I am not sure if we can make it optional. There 
can be situations when the polygon is invalid but it actually does not fail 
when it is tessellated. We have an example in the tests, where the polygon 
looks like:
   
   <img width="400" alt="image" 
src="https://user-images.githubusercontent.com/29038686/95737373-d8105780-0c87-11eb-9f1f-3bd16e392067.png";>
   
   This polygon is invalid and the new check will throw an error but it does 
not fail if you try to tessellate it. The documentation of the 'Tessellator` 
explicitly says that:
   
   ```
   Holes may only touch at one vertex
   ```
   IMHO I think we should fail in this case.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org