sigram commented on a change in pull request #1964:
URL: https://github.com/apache/lucene-solr/pull/1964#discussion_r503146425
##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -168,6 +172,33 @@ public CoreLoadFailure(CoreDescriptor cd, Exception
loadFailure) {
}
}
+ public static class ClusterSingletons {
Review comment:
That's the downside of splitting this PR into API & implementation ...
The way we load CC it's nearly impossible to properly initialize singletons
from within the load() method if we don't defer the initialization until the
load() is completed. `ClusterSingletons` class is just a helper for deferred
init of singletons once they are all discovered and loaded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
