[
https://issues.apache.org/jira/browse/LUCENE-6831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212176#comment-17212176
]
ASF subversion and git services commented on LUCENE-6831:
---------------------------------------------------------
Commit 7362c4ce603d81f276a83070e51bda52c3528bd7 in lucene-solr's branch
refs/heads/master from Dawid Weiss
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=7362c4c ]
LUCENE-6831: start removing LinkedList in favor of ArrayList or De/Queues
(#1969)
I'm committing it in, seems like a trivial thing.
> Review LinkedList usage
> -----------------------
>
> Key: LUCENE-6831
> URL: https://issues.apache.org/jira/browse/LUCENE-6831
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Dawid Weiss
> Priority: Trivial
> Fix For: 6.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> I quickly scanned the code (out of curiosity) and most of the use cases of
> LinkedList are as a Queue, in which case indeed an ArrayDeque would be a
> better choice, especially if the maximum size is known in advance.
> There are also some invalid/ incorrect uses like calling size() on a linked
> list in {{MultiPhraseQueryNodeBuilder}}, which should be fixed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
