gus-asf commented on pull request #1966: URL: https://github.com/apache/lucene-solr/pull/1966#issuecomment-705915297
In retrospect/review I can see that my solution does have some additional problems that probably just haven't been showing up yet because the cases in question aren't that common in the actual usage (but probably will crop up eventually). More importantly even if it did have a benefit in a particular case, a component in a library it shouldn't buck the behavioral trend like that. I did arrive there for a reason however. I just hope you can understand that if one reads the documentation, does some work with it and then forgets something after not using it for a year or so, it can be hard to know that you've have forgotten something, especially when what you do remember _seems_ to be working. Would be nice if lucene had docs that included a table of contents or navigation by topic so that one didn't have to wade through a single (or a small number of) giant javadoc pages with many sections unrelated to whatever one is actually trying to understand at the moment. Unfortunately this will have knock on effects on some other parts of the SIP, mostly because I need to solve the "extra" synonym problem now, because instead of sometimes loosing a single position, I'll now gain N positions where N is the number of times a synonym generating token got split before synonyms were generated, magnifying the problem and pushing it in a direction much more noticeable to users. Such is life and it's probably better in the long run. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
