dweiss commented on pull request #1950: URL: https://github.com/apache/lucene-solr/pull/1950#issuecomment-705162646
The less of the manual configuration we do, the better I think. If google orders imports then we should just let it do it. It hooks into the javac compiler AST so I think it has all the necessary information not only to sort the imports but also to resolve them properly (static imports, etc.). On Wed, Oct 7, 2020 at 9:35 PM David Smiley <notificati...@github.com> wrote: > I believe you :-). > > The configuration I saw suggests in spotless suggests we have control over > the import order. Shouldn't we configure the order as we find to be most > consistent in our codebase? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/lucene-solr/pull/1950#issuecomment-705150200>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AABQWLRFDJRYXY5D243YZIDSJS7JHANCNFSM4SFU2VTQ> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
