[
https://issues.apache.org/jira/browse/LUCENE-9558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida updated LUCENE-9558:
----------------------------------
Description:
analyzers-icu module shares the package names {{o.a.l.collation}} and
{{o.a.l.collation.tokenattributes}} with analyzers-common; they need to be
renamed.
There could be two solutions:
1. rename "o.a.l.collation" to "o.a.l.a.icu.collation"
2. move classes under "o.a.l.collation" to "o.a.l.a.icu" and classes under
"o.a.l.collation.tokenattributes" to "o.a.l.a.icu.tokenattributes", and delete
"o.a.l.collation" from analyzers-icu
I would prefer option 2. 1. may complicate the package hierarchy and there
already exist {{o.a.l.a.icu.tokenattributes}}. (All classes under
"o.a.l.collation" have prefix "ICUCollation", so I think we don't need to keep
"collation" in the package name, do we?)
was:
analyzers-icu module shares the package names {{o.a.l.collation}} and
{{o.a.l.collation.tokenattributes}} with analyzers-common; they need to be
renamed.
There could be two solutions:
1. rename "o.a.l.collation" to "o.a.l.a.icu.collation"
2. move classes under "o.a.l.collation" to "o.a.l.a.icu" and classes under
"o.a.l.collation.tokenattributes" to "o.a.l.a.icu.tokenattributes", and delete
"o.a.l.collation" from analyzers-icu
I would prefer option 2. 1. may complicate the package hierarchy and there
already exist {{o.a.l.a.icu.tokenattributes}}. (All classes under
"o.a.l.collation" have prefix "ICU", so I think we don't need to keep
"collation" in the package name, do we?)
> Clean up package name conflicts for analyzers-icu module
> --------------------------------------------------------
>
> Key: LUCENE-9558
> URL: https://issues.apache.org/jira/browse/LUCENE-9558
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/analysis
> Reporter: Tomoko Uchida
> Assignee: Tomoko Uchida
> Priority: Minor
>
> analyzers-icu module shares the package names {{o.a.l.collation}} and
> {{o.a.l.collation.tokenattributes}} with analyzers-common; they need to be
> renamed.
> There could be two solutions:
> 1. rename "o.a.l.collation" to "o.a.l.a.icu.collation"
> 2. move classes under "o.a.l.collation" to "o.a.l.a.icu" and classes under
> "o.a.l.collation.tokenattributes" to "o.a.l.a.icu.tokenattributes", and
> delete "o.a.l.collation" from analyzers-icu
> I would prefer option 2. 1. may complicate the package hierarchy and there
> already exist {{o.a.l.a.icu.tokenattributes}}. (All classes under
> "o.a.l.collation" have prefix "ICUCollation", so I think we don't need to
> keep "collation" in the package name, do we?)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
