[ 
https://issues.apache.org/jira/browse/LUCENE-9032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205960#comment-17205960
 ] 

ASF subversion and git services commented on LUCENE-9032:
---------------------------------------------------------

Commit 9b5823fa72acb432346e9096fe322a645fdeaf8c in lucene-solr's branch 
refs/heads/branch_8x from David Smiley
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=9b5823f ]

LUCENE-9032: BaseTokenStreamTestCase minor...
* make checkResetException() public
* one assertAnalyzesTo variant should be calling checkAnalysisConsistency (only 
used by OpenNLP tests now)

(cherry picked from commit 2aa51fe77caf60392f1352076888e447ad2b56e0)


> Make public: BaseTokenStreamTestCase.checkResetException
> --------------------------------------------------------
>
>                 Key: LUCENE-9032
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9032
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/test-framework
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>
> Ideally {{BaseTokenStreamTestCase.checkResetException}} would be public so 
> that 3rd party projects can test this.  assertTokenStreamContents is public, 
> checkAnalysisConsistency is public, assertAnalyzesTo is public.  It's 
> currently possible to _indirectly_ get this check because assertAnalyzesTo 
> will call it, but this forces the use of RandomizedTesting and 3rd parties 
> might not be using that.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to