ctargett commented on pull request #1923: URL: https://github.com/apache/lucene-solr/pull/1923#issuecomment-702230956
What happened in the past when I attempted to move to Jekyll 4 is that the .adoc files just simply wouldn't be converted to HTML - it would say there were no files to convert. This is what happened when Jenkins moved to Cloudbees and the wrong version caused the Jenkins build for branch_8x to fail for 2 months until Infra fixed the gemset installed on the nodes to install specifically Jekyll 3.5.2. That seems to be working fine now here because you (I think inadvertently because you didn't mention reading the Jekyll docs on migrating from 3 to 4) hit upon the cause of the problem which was the way the `jekyll-asciidoc` plugin in `_config.yml` was defined: using `gems` to define it was deprecated and that deprecation was removed in Jekyll 4 so the only supported way to do it is now `plugins`. Which is what this PR (and Hoss' patch from SOLR-14889, now in master) changes it to. This all makes sense - Jekyll doesn't know anything about .adoc files without the plugin. I did read the migration docs for Jekyll and I don't see anything that we should be concerned about that should require more extensive review before making the change. Knowing why it failed before and why it isn't now makes me feel easier about upgrading entirely. Re: the syntax highlighter styling. I tested both ways of doing it, and noticed a small difference in overall size (1Mb) and makes the HTML a bit simpler if we include it as a CSS file. By the same token, as I mentioned that CSS is something we have to maintain going forward. But I am leaning toward being OK with going the CSS route. I think, though, that it needs some attribution in the CSS file itself - license/copyright info and comments about where we got it so it's clear where to go in the future when it needs to be updated. Hoss's changes from SOLR-14889 are committed to `master` now, so this needs to be updated to take out the stuff you're doing that is now already in `master`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
