markrmiller commented on a change in pull request #1932:
URL: https://github.com/apache/lucene-solr/pull/1932#discussion_r497827172
##########
File path: solr/test-framework/src/java/org/apache/solr/SolrTestCase.java
##########
@@ -279,7 +292,6 @@ public static void setDefaultConfigDirSysPropIfNotSet()
throws Exception {
System.setProperty("solr.http2solrclient.maxpool.size", "12");
System.setProperty("solr.http2solrclient.pool.keepalive", "1500");
Review comment:
Let's enable reuse here instead.
##########
File path: solr/test-framework/src/java/org/apache/solr/SolrTestCase.java
##########
@@ -225,7 +238,7 @@ public static void setDefaultConfigDirSysPropIfNotSet()
throws Exception {
System.setProperty("solr.clustering.enabled", "false");
System.setProperty("solr.peerSync.useRangeVersions",
String.valueOf(random().nextBoolean()));
System.setProperty("zookeeper.nio.directBufferBytes", Integer.toString(32
* 1024 * 2));
- System.setProperty("solr.disablePublicKeyHandler", "true");
+ enableReuseOfCryptoKeys();
Review comment:
Looks like I had this reversed. We should likely enable reuse below in
the non Nightly run and disable for the closer to prod Nightly run.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
