[
https://issues.apache.org/jira/browse/SOLR-14835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17203835#comment-17203835
]
Andrzej Bialecki commented on SOLR-14835:
-----------------------------------------
As far as I can tell this is a bogus warning - the instrumented threadpool is
still being correctly created and it correctly reports its metrics to the
{{solr.jetty}} registry.
I found the following information from the Jetty project that confirms this:
* One of the comments on [Issue
4631|https://github.com/eclipse/jetty.project/issues/4631#issuecomment-593655806]
explicitly says that the configuration is still being processed and it's just
the order of arguments in the config that causes this bogus warning. Note that
this order of arguments is actually the one that is recommended in the
documentation and changing it (so that the {{<Arg>}} section comes later)
produces fatal errors.
* this issue further links to [PR
4632|https://github.com/eclipse/jetty.project/pull/4632] that fixes this bogus
warning in Jetty 9.4.28.
So for the 8.6.3 release I think we should simply add a note in CHANGES.txt
saying that this is a bogus warning that can be ignored. Also, before 8.7 we
should upgrade Jetty to at least 9.4.28 where this warning has been fixed.
> Solr 8.6.x log starts with "XmlConfiguration Ignored arg" warning from Jetty
> ----------------------------------------------------------------------------
>
> Key: SOLR-14835
> URL: https://issues.apache.org/jira/browse/SOLR-14835
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Affects Versions: 8.6.2
> Reporter: Colvin Cowie
> Assignee: Andrzej Bialecki
> Priority: Trivial
>
> After moving to 8.6.2 the first lines of the solr.log are
> {noformat}
> 2020-09-06 18:19:09.164 INFO (main) [ ] o.e.j.u.log Logging initialized
> @1197ms to org.eclipse.jetty.util.log.Slf4jLog
> 2020-09-06 18:19:09.226 WARN (main) [ ] o.e.j.u.l.o.e.j.x.XmlConfiguration
> Ignored arg: <Arg name="threadpool">
> <New id="threadpool"
> class="com.codahale.metrics.jetty9.InstrumentedQueuedThreadPool"><Arg
> name="registry">
> <Call id="solrJettyMetricRegistry" name="getOrCreate"
> class="com.codahale.metrics.SharedMetricRegistries"><Arg>solr.jetty</Arg></Call>
> </Arg></New>
> </Arg>
> {noformat}
> This config is declared here:
> https://github.com/apache/lucene-solr/blob/5154b6008f54c9d096f5efe9ae347492c23dd780/solr/server/etc/jetty.xml#L33
> and has been there for a long time, so I assume it's the bump in Jetty
> version that's causing it now.
> I'm seeing this in 8.6.2, but I've not gone back to check other versions
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
