sigram commented on pull request #1758:
URL: https://github.com/apache/lucene-solr/pull/1758#issuecomment-698204377


   > an example of how you register some type of plugin
   
   Still open for suggestions. IMHO `ClusterEventListener`-s make sense only if 
they are also `ClusterSingleton`-s. If that's the case then there's that messy 
section in `CoreContainer` that already registers `ClusterSingleton`-s, and we 
can add a section that additionally registers any instance that implements 
`ClusterEventListener` with the `ClusterEventProducer`.
   
   > how it looks in some JSON in ZK
   
   I'm reusing the plugin-s configs from `CustomContainerPlugins` so it will 
look like any other plugin config.
   
   > If a plugin can be registered using a public API, is there a testcase for 
the same?
   
   Not yet :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to