noblepaul commented on a change in pull request #1906: URL: https://github.com/apache/lucene-solr/pull/1906#discussion_r494062845
########## File path: solr/core/src/java/org/apache/solr/servlet/RateLimiterConfig.java ########## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.servlet; Review comment: I don't think it should belong here. only servlet filters etc are supposed to be there. ########## File path: solr/core/src/java/org/apache/solr/handler/ClusterAPI.java ########## @@ -171,10 +172,30 @@ public void setPlacementPlugin(PayloadObj<Map<String, Object>> obj) { // Need to reset to null first otherwise the mappings in placementPluginConfig are added to existing ones // in /clusterprops.json rather than replacing them. If removing the config, that's all we do. clusterProperties.setClusterProperties( - Collections.singletonMap(PlacementPluginConfigImpl.PLACEMENT_PLUGIN_CONFIG_KEY, null)); + Collections.singletonMap(PlacementPluginConfigImpl.PLACEMENT_PLUGIN_CONFIG_KEY, null)); + if (!unset) { Review comment: `clusterProperties.setClusterProperties()` is a ZK write op. We are doing 2 operations here. We must avoid it ########## File path: solr/core/src/java/org/apache/solr/handler/ClusterAPI.java ########## @@ -206,7 +209,7 @@ public void setObjProperty(PayloadObj<ClusterPropInfo> obj) { public void setProperty(PayloadObj<Map<String,String>> obj) throws Exception { Map<String,Object> m = obj.getDataMap(); m.put("action", CLUSTERPROP.toString()); - collectionsHandler.handleRequestBody(wrapParams(obj.getRequest(),m ), obj.getResponse()); + collectionsHandler.handleRequestBody(wrapParams(obj.getRequest(), m), obj.getResponse()); Review comment: why is there a change here? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
