goankur commented on a change in pull request #1893:
URL: https://github.com/apache/lucene-solr/pull/1893#discussion_r494637269
##########
File path:
lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyFacetCounts.java
##########
@@ -711,6 +723,11 @@ public void testRandom() throws Exception {
}
}
+ // Test facet labels for each matching test doc
+ List<List<FacetLabel>> actualLabels = getTaxonomyFacetLabels(tr, config,
fc);
+ assertEquals(expectedLabels.size(), actualLabels.size());
Review comment:
Nice catch, thanks. I fixed `actualLabels` generation in
`FacetTestCase.getAllTaxonomyFacetLabels()` method to filter out empty
`List<facetLabels>`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
