[ https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201378#comment-17201378 ]
Ilan Ginzburg commented on SOLR-14613: -------------------------------------- [~noble.paul] could we change {{setClusterProperty(String propertyName, Object propertyValue)}} in {{ClusterProperties}} to replace the existing property value with the passed one, or do we really need this "partial" update behavior? (where existing Json in {{clusterprops.json}} for {{propertyName}} is merged rather than replaced with the new Json of {{propertyValue}}) If we can't change the existing method, I suggest the added one to have a consistent signature, i.e. define *{{update(String propertyName, Object propertyValue)}}* rather than {{update(MapWriter obj, String... path)}}. This will make {{ClusterAPI}} easier to read and move the configuration management implementation details to {{ClusterProperties}} where they belong. > Provide a clean API for pluggable replica assignment implementations > -------------------------------------------------------------------- > > Key: SOLR-14613 > URL: https://issues.apache.org/jira/browse/SOLR-14613 > Project: Solr > Issue Type: Improvement > Components: AutoScaling > Reporter: Andrzej Bialecki > Assignee: Ilan Ginzburg > Priority: Major > Time Spent: 41h > Remaining Estimate: 0h > > As described in SIP-8 the current autoscaling Policy implementation has > several limitations that make it difficult to use for very large clusters and > very large collections. SIP-8 also mentions the possible migration path by > providing alternative implementations of the placement strategies that are > less complex but more efficient in these very large environments. > We should review the existing APIs that the current autoscaling engine uses > ({{SolrCloudManager}} , {{AssignStrategy}} , {{Suggester}} and related > interfaces) to see if they provide a sufficient and minimal API for plugging > in alternative autoscaling placement strategies, and if necessary refactor > the existing APIs. > Since these APIs are internal it should be possible to do this without > breaking back-compat. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org