arafalov opened a new pull request #1897:
URL: https://github.com/apache/lucene-solr/pull/1897


   # Description
   
   We moved Terms Components and Terms Request Handler into default definition, 
but the request handler did not define any defaults. Therefore, we still had an 
overriding definition hanging around in solrconfig.xml, confusing things. 
Additionally, documentation was out of date too.
   
   # Solution
   
   1. Updated default definition for /terms request handler to match what 
solrconfig.xml had (terms=true to actually make that handler useful and 
distrib=false)
   2. Removed definition from default configsets
   3. Cleaned up tests that no longer needed to enable the component every time
   4. Updated documentation to reflect the implicit aspects and to give an 
example of using it with other handlers
   
   # Tests
   1. No new tests, but updated the existing ones to rely on updated definition 
and not to declare it explicitly.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [X] I have reviewed the guidelines for [How to 
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms 
to the standards described there to the best of my ability.
   - [X] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [X] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [X] I have developed this patch against the `master` branch.
   - [X] I have run `./gradlew check`.
   - [X] I have added (updated) tests for my changes.
   - [X] I have added documentation for the [Ref 
Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) 
(for Solr changes only).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to