cpoerschke opened a new pull request #1890: URL: https://github.com/apache/lucene-solr/pull/1890
As part of https://issues.apache.org/jira/browse/LUCENE-8626 I noticed that we have both * https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.6.2/solr/core/src/test/org/apache/solr/cloud/ConfigSetsAPITest.java and * https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.6.2/solr/core/src/test/org/apache/solr/cloud/TestConfigSetsAPI.java which is mildly confusing. I also note that * https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.6.2/solr/core/src/test/org/apache/solr/cloud/TestConfigSetsAPIExclusivity.java and * https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.6.2/solr/core/src/test/org/apache/solr/cloud/TestConfigSetsAPIZkFailure.java exist in the same package i.e. this part of the code base favours `Test*.java` naming. Something like "TestConfigSetsAPISolrCloud" more accurately describes what the "ConfigSetsAPITest" test does. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
