cpoerschke commented on a change in pull request #1825:
URL: https://github.com/apache/lucene-solr/pull/1825#discussion_r488821736
##########
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/BaseCloudSolrClient.java
##########
@@ -994,12 +991,15 @@ public RouteException(ErrorCode errorCode,
NamedList<Throwable> throwables, Map<
// and we could not get any information from the server
//it is probably not worth trying again and again because
// the state would not have been updated
- log.info("trying request again");
+ log.info("Request to collection {} failed due to ({}) {}, retry={}
maxRetries={} commError={} errorCode={} - retrying",
+ inputCollections, errorCode, rootCause, retryCount,
MAX_STALE_RETRIES, wasCommError, errorCode);
return requestWithRetryOnStaleState(request, retryCount + 1,
inputCollections);
}
} else {
log.info("request was not communication error it seems");
}
+ log.error("Request to collection {} failed due to ({}) {}, retry={}
maxRetries={} commError={} errorCode={} ",
Review comment:
```suggestion
log.info("Request to collection {} failed due to ({}) {}, retry={}
maxRetries={} commError={} errorCode={} ",
```
@noblepaul - is this what you had in mind when you wrote "switch this to
INFO" on the https://issues.apache.org/jira/browse/SOLR-14828 ticket? Or would
you prefer keeping the logging at line 973 only but as `INFO` instead of
`ERROR`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
