[ 
https://issues.apache.org/jira/browse/SOLR-14723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17196241#comment-17196241
 ] 

Shashank Shekhar edited comment on SOLR-14723 at 9/15/20, 4:26 PM:
-------------------------------------------------------------------

Cool, so I will remove the class attribute from the caches mentioned above by 
you. Then run the tests and proceed with debugging if the tests still fail on 
my modified branch. Thank-you for the debugging tips. I think these will 
definitely help. 

After a closer look on all the files to be edited I think editing the _xml_s 
via a python script makes more sense than manually editing them. There are 
close to 45 files to be edited. The script can parse the xml, remove the class 
attribute from the cache tags and write it back. 


was (Author: shshnk28):
Cool, so I will remove the class attribute from the caches mentioned above by 
you. Then run the tests and proceed with debugging if the tests still fail on 
my modified branch. Thank-you for the debugging tips. I think these will 
definitely help. 

> Rremove the class atribute for the caches in the _default/example configsets
> ----------------------------------------------------------------------------
>
>                 Key: SOLR-14723
>                 URL: https://issues.apache.org/jira/browse/SOLR-14723
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Tomas Eduardo Fernandez Lobbe
>            Priority: Trivial
>              Labels: newdev
>
> In 8.x branch, the default and example configsets include LRUCache and 
> FastLRUCache as the implementation for the various caches.
> {code:xml}
> <filterCache class="solr.FastLRUCache"
>                  size="512"
>                  initialSize="512"
>                  autowarmCount="0"/>
> {code}
> Those implementations are deprecated. We should remove the attribute 
> completely and let the default take over (as it's in master), this should 
> make upgrading configsets easier:



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to