uschindler commented on a change in pull request #1860:
URL: https://github.com/apache/lucene-solr/pull/1860#discussion_r488771433
##########
File path: dev-tools/scripts/buildAndPushRelease.py
##########
@@ -108,37 +107,26 @@ def prepare(root, version, gpgKeyID, gpgPassword):
print(' Check DOAP files')
checkDOAPfiles(version)
- print(' ant -Dtests.badapples=false clean validate documentation-lint test')
- run('ant -Dtests.badapples=false clean validate documentation-lint test')
+ print(' ./gradlew -Dtests.badapples=false clean check')
+ run('./gradlew -Dtests.badapples=false clean check')
open('rev.txt', mode='wb').write(rev.encode('UTF-8'))
- print(' lucene prepare-release')
- os.chdir('lucene')
- cmd = 'ant -Dversion=%s' % version
+ print(' prepare-release')
+ cmd = './gradlew -Dversion=%s clean' % version
Review comment:
This must be `-Dversion.release=%s`, as gradle has some reserved meaning
of `version`.
##########
File path: dev-tools/scripts/releaseWizard.yaml
##########
@@ -1059,7 +1056,7 @@ groups:
logfile: checkout-release-tag.log
tee: true
- !Command
- cmd: ant documentation -Dversion={{ release_version }}
+ cmd: "{{ gradle_cmd }} documentation -Dversion={{ release_version }}"
Review comment:
This must be `-Dversion.release=%s`, as gradle has some reserved meaning
of `version`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
