murblanc commented on a change in pull request #1845:
URL: https://github.com/apache/lucene-solr/pull/1845#discussion_r488566052
##########
File path: solr/solrj/src/resources/apispec/cluster.Commands.json
##########
@@ -141,6 +141,21 @@
}
}
}
- }
+ },
+ "set-placement-plugin": {
Review comment:
Or, put differently (if there's no simple way to use annotations for the
two new commands): when the existing 4 commands are migrated, migrating with
them the two new ones is likely not going to make the task any harder.
Keeping the new definitions in apispecs would therefore make sense for now
for the sake of simplicity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
