[
https://issues.apache.org/jira/browse/LUCENE-9411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17195590#comment-17195590
]
ASF subversion and git services commented on LUCENE-9411:
---------------------------------------------------------
Commit 5083e02e3c88bfc388650ee682bfa6467d4202ad in lucene-solr's branch
refs/heads/reference_impl_gradle_updates from Erick Erickson
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=5083e02 ]
LUCENE-9411: Fail complation on warnings, 9x gradle-only. Explicitly list
warnings to check for
> Fail complation on warnings, 9x gradle-only
> -------------------------------------------
>
> Key: LUCENE-9411
> URL: https://issues.apache.org/jira/browse/LUCENE-9411
> Project: Lucene - Core
> Issue Type: Improvement
> Components: general/build
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
> Labels: build
> Fix For: master (9.0)
>
> Attachments: LUCENE-9411-explicit-warnings.patch, LUCENE-9411.patch,
> LUCENE-9411.patch, LUCENE-9411.patch, LUCENE-9411.patch,
> annotations-warnings.patch
>
>
> Moving this over here from SOLR-11973 since it's part of the build system and
> affects Lucene as well as Solr. You might want to see the discussion there.
> We have a clean compile for both Solr and Lucene, no rawtypes, unchecked,
> try, etc. warnings. There are some peculiar warnings (things like
> SuppressFBWarnings, i.e. FindBugs) that I'm not sure about at all, but let's
> assume those are not a problem. Now I'd like to start failing the compilation
> if people write new code that generates warnings.
> From what I can tell, just adding the flag is easy in both the Gradle and Ant
> builds. I still have to prove out that adding -Werrors does what I expect,
> i.e. succeeds now and fails when I introduce warnings.
> But let's assume that works. Are there objections to this idea generally? I
> hope to have some data by next Monday.
> FWIW, the Lucene code base had far fewer issues than Solr, but
> common-build.xml is in Lucene.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
