madrob commented on a change in pull request #1843:
URL: https://github.com/apache/lucene-solr/pull/1843#discussion_r485210946
##########
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientBuilderFactory.java
##########
@@ -36,7 +35,7 @@
* by configured (optional).
* @return the {@linkplain SolrHttpClientBuilder}
*/
- public SolrHttpClientBuilder
getHttpClientBuilder(Optional<SolrHttpClientBuilder> builder);
+ public SolrHttpClientBuilder getHttpClientBuilder(SolrHttpClientBuilder
builder);
Review comment:
Yea, since we're changing APIs here, it would have to probably be 9 only
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
