[ https://issues.apache.org/jira/browse/SOLR-14846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17192418#comment-17192418 ]
Varun Thacker commented on SOLR-14846: -------------------------------------- Thanks for linking the video! I think the changes makes sense! > Avoid use of Optional.ofNullable.orElse in the same line > -------------------------------------------------------- > > Key: SOLR-14846 > URL: https://issues.apache.org/jira/browse/SOLR-14846 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Mike Drob > Assignee: Mike Drob > Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Optional was meant to be used in public APIs to convey to the caller that > they really need to null-check, not as an internal class to avoid doing our > own null checks. There are better methods in {{Objects}} for that if we want > them. > See also Brian Goetz at JavaOne - https://youtu.be/MFzlgAuanU0?t=2719 -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org