[
https://issues.apache.org/jira/browse/LUCENE-9504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob resolved LUCENE-9504.
-------------------------------
Fix Version/s: master (9.0)
Resolution: Fixed
> DocumentsWriterDeleteQueue.forceApplyGlobalSlice has needless locking
> ---------------------------------------------------------------------
>
> Key: LUCENE-9504
> URL: https://issues.apache.org/jira/browse/LUCENE-9504
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
> Reporter: Mike Drob
> Assignee: Mike Drob
> Priority: Minor
> Fix For: master (9.0)
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {{DocumentsWriterDeleteQueue.forceApplyGlobalSlice}} is only called from
> {{getBufferedUpdateTermsSize}} so we end up doing double the locking. It's
> not a huge problem because re-entrant locks are cheap, but we can probably
> unwrap the methods a little bit here.
> This may impact HotSpot inlining, I haven't tried measuring that yet. If that
> is a concern, please let me know.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
