[ https://issues.apache.org/jira/browse/LUCENE-9498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190979#comment-17190979 ]
David Smiley commented on LUCENE-9498: -------------------------------------- I think it would be weird to separate one highlighter from the "highlighter" module simply because of these dependencies. The "memory" (MemoryIndex) dependency is fantastic for re-analysis of stored text. It's so useful and so small... I kinda wonder if it'd be better off in lucene-core. Even in spatial is in lucene-core these days! The "queries" dependency is only there because the other highlighters detect certain Query subclasses there to know how to highlight them. The Matches API makes that approach obsolete. The new "matches" highlighter/framework exclusively uses that new API, and the UnifiedHighlighter is dual-mode; can use it or not as one prefers. There's an issue to make it use this default starting in 9.0. > Move matchhighlighter to a separate subproject > ---------------------------------------------- > > Key: LUCENE-9498 > URL: https://issues.apache.org/jira/browse/LUCENE-9498 > Project: Lucene - Core > Issue Type: Sub-task > Reporter: Dawid Weiss > Assignee: Dawid Weiss > Priority: Minor > > This is a trivial thing to do (on master at least). Match highlighter has no > other dependencies. It sort of fits in the "highlighter" package but this > package depends on {{queries}} and {{memory}} packages. I wonder if we should > move it to a separate subproject? -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org