jtibshirani opened a new pull request #1834: URL: https://github.com/apache/lucene-solr/pull/1834
When a query is run at the top-level, the searcher uses `Weight#bulkScorer`. Many queries don't implement this explicitly and instead rely on the default implementation which delegates to `Weight#scorer`. Previously `AssertingWeight` would always wrap the delegate's bulk scorer. So for queries that rely on `Weight#scorer`, we weren't wrapping the scorer or iterator to run checks. This change proposes that `AssertingWeight#bulkScorer` sometimes use the default implementation to make sure we also test normal scorers. This change would have caught the bug in LUCENE-9501. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
