dweiss commented on a change in pull request #1828: URL: https://github.com/apache/lucene-solr/pull/1828#discussion_r483793090
########## File path: lucene/core/src/java/org/apache/lucene/analysis/CharArrayMap.java ########## @@ -523,6 +523,7 @@ public void clear() { * @throws NullPointerException * if the given map is <code>null</code>. */ + @SuppressWarnings("ReferenceEquality") Review comment: Yes, exactly. I wanted the pr to include an example of how this can be done. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org