noblepaul commented on a change in pull request #1815:
URL: https://github.com/apache/lucene-solr/pull/1815#discussion_r483562559
##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -1582,6 +1582,13 @@ private CoreDescriptor
reloadCoreDescriptor(CoreDescriptor oldDesc) {
public void reload(String name) {
reload(name, null);
}
+ public void reload(String name, UUID coreId, boolean async) {
+ if(async) {
+ runAsync(() -> reload(name, coreId));
+ } else {
+ reload(name, coreId);
+ }
+ }
Review comment:
It's a generic method. I thought I would use it. But there are bugs in
our core reloading. So, if I use asyn reload, some tests fail
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
