rmuir commented on pull request #1802: URL: https://github.com/apache/lucene-solr/pull/1802#issuecomment-685687970
I've added missing javadocs and reset visibility for the remaining classes, with one or two exceptions (and if you look at those, its clear the visibility was straight up wrong, because nothing else in the class (fields, methods) is visible. Frankly, If we want to get this in and remove the python, now is the time I think. Otherwise let's decide we really like the python because that goddamn thing has been *way* too hard to get rid of. I'm just simply not going to be able to keep up with the new changes in master due to time constraints. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
