kwatters opened a new pull request #1810: URL: https://github.com/apache/lucene-solr/pull/1810
…ll fails. <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr: * https://issues.apache.org/jira/projects/LUCENE * https://issues.apache.org/jira/projects/SOLR You will need to create an account in Jira in order to create an issue. The title of the PR should reference the Jira issue number in the form: * LUCENE-####: <short description of problem or changes> * SOLR-####: <short description of problem or changes> LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description This is a change to the payload check query parser. It allows users to pass an "op" and a "threshold" value as a local param. Those are wired through to the SpanPayloadCheck lucene query. For delimited payload fields with a float, this threshold will be compared against the payload of the matching term using the appropriate inequality operation of gt, gte, lt, lte (for > < >= <= ) # Solution This makes the span payload check query a bit more flexible in that you can swap in a different compare method for the payloads. This should be reasonably extensible. # Tests This works on and adds a test case to the TestPayloadCheckQParser. One item of note, one of the existing text cases in this unit test appears to have started failing between 8.2.0 and 8.3.0 (for some reason the payloads are coming back lower cased instead of the original byte value of upper cased. I have not tracked down what changes might be responsible for that change.) # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [ ] I have developed this patch against the `master` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
