dsmiley commented on a change in pull request #1769:
URL: https://github.com/apache/lucene-solr/pull/1769#discussion_r479682955
##########
File path: solr/docker/docs/docker-compose.yml
##########
@@ -0,0 +1,13 @@
+version: '3'
+services:
+ solr:
+ image: solr
Review comment:
Here and probably some README type places, the assumption is that the
image is named "solr". Yet it appears that you're deciding that the name
"apache/solr" is the new default name. I think pick one or or the other.
##########
File path: solr/docker/tests/shared.sh
##########
@@ -90,18 +90,44 @@ function prepare_dir_to_mount {
fi
rm -fr "$folder" >/dev/null 2>&1
mkdir "$folder"
- #echo "***** Created varsolr folder $PWD / $folder"
+ #echo "***** Created varsolr folder $BUILD_DIR / $folder"
# The /var/solr mountpoint is owned by solr, so when we bind mount there our
directory,
# owned by the current user in the host, will show as owned by solr, and our
attempts
# to write to it as the user will fail. To deal with that, set the ACL to
allow that.
# If you can't use setfacl (eg on macOS), you'll have to chown the directory
to 8983, or apply world
# write permissions.
- if [[ "$OSTYPE" == "darwin"* ]]; then
- # Workaround for macOS
- sudo chmod -R 777 "$folder"
- sudo chown -R "$userid" "$folder"
- else
+ if command -v setfacl &> /dev/null; then
setfacl -m "u:$userid:rwx" "$folder"
fi
}
+
+
+# Shared setup
Review comment:
Are you making general improvements to the test scripts, or do they
relate to necessities of the port to lucene-solr? I suggest suppressing your
natural urge to improve code in a porting job to limit to just do the port.
Future work items can refactor common code out of bash scripts or whatever else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]