[
https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186891#comment-17186891
]
Noble Paul edited comment on SOLR-14613 at 8/29/20, 6:29 AM:
-------------------------------------------------------------
-1 for this to merge into core.
There are 108 files. This should be out of Solr core. There is no justification
for such a minor feature to be such a big change to core Solr
We have massively increased the API surface area of Solr for a trivial feature
such as replica placement. Lets not forget that we are doing all this to
slightly improve the functionality of this class which is around 40 lines of
code. This is a classic example of overengineering
https://github.com/apache/lucene-solr/blob/8bd367832f68e7329373315dfada715c2ffe03bc/solr/core/src/java/org/apache/solr/cloud/api/collections/Assign.java#L453
was (Author: noble.paul):
-1 for this to merge into core.
There are 108 files. This should be out of Solr core. There is no justification
for such a minor feature to be such a big change to core Solr
We have massively increased the API surface area of Solr for a trivial feature
such as replica placement. Lets not forget that we are doing all this to
slightly improve the functionality of this class which is arounf 40 lines of
code. This is a classic example of overengineering
https://github.com/apache/lucene-solr/blob/8bd367832f68e7329373315dfada715c2ffe03bc/solr/core/src/java/org/apache/solr/cloud/api/collections/Assign.java#L453
> Provide a clean API for pluggable replica assignment implementations
> --------------------------------------------------------------------
>
> Key: SOLR-14613
> URL: https://issues.apache.org/jira/browse/SOLR-14613
> Project: Solr
> Issue Type: Improvement
> Components: AutoScaling
> Reporter: Andrzej Bialecki
> Assignee: Ilan Ginzburg
> Priority: Major
> Time Spent: 20h 40m
> Remaining Estimate: 0h
>
> As described in SIP-8 the current autoscaling Policy implementation has
> several limitations that make it difficult to use for very large clusters and
> very large collections. SIP-8 also mentions the possible migration path by
> providing alternative implementations of the placement strategies that are
> less complex but more efficient in these very large environments.
> We should review the existing APIs that the current autoscaling engine uses
> ({{SolrCloudManager}} , {{AssignStrategy}} , {{Suggester}} and related
> interfaces) to see if they provide a sufficient and minimal API for plugging
> in alternative autoscaling placement strategies, and if necessary refactor
> the existing APIs.
> Since these APIs are internal it should be possible to do this without
> breaking back-compat.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
