[
https://issues.apache.org/jira/browse/LUCENE-9478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17183558#comment-17183558
]
ASF subversion and git services commented on LUCENE-9478:
---------------------------------------------------------
Commit 098f0dc8b414ca9c9a47cf7ebf4383198fb946fe in lucene-solr's branch
refs/heads/master from Simon Willnauer
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=098f0dc ]
LUCENE-9478: Prevent DWPTDeleteQueue from referencing itself and leaking memory
(#1779)
In LUCENE-9304 we introduced some fixes that unfortunately hold on to the
previous
DWPTDeleteQueue which is essentially leaking IW memory and cause applications
to fail.
This fixes the memory leak and adds a test to ensure its not leaking memory.
> DWPTDeleteQueue leaks memory
> ----------------------------
>
> Key: LUCENE-9478
> URL: https://issues.apache.org/jira/browse/LUCENE-9478
> Project: Lucene - Core
> Issue Type: Bug
> Affects Versions: master (9.0), 8.7, 8.6.1
> Reporter: Simon Willnauer
> Priority: Blocker
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> We introduced a broken behavior that leaks memory in DWPTDeleteQueue recently
> (LUCENE-9304) The line
> [here|https://github.com/apache/lucene-solr/blob/18af6325ed98b50c23a1f026ab9d05f17039c731/lucene/core/src/java/org/apache/lucene/index/DocumentsWriterDeleteQueue.java#L594-L596]
> tries to be smart and even adds a comment that the current impl is safe but
> it isn't if you reference a final member in a lambda it references _this_
> which holds on to the object. I think we need to do a quick 8.6.2 for this.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
